Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

926 spotify network error narrowcasting #933

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

supertom01
Copy link
Member

Please add the following information to your pull request:

Please describe what your PR is fixing
Catches the correct ConnectionError exception. There is both one defined within Python system and one by the requests library. Initially we would only catch the one from the Python system, which is most likely not the correct one.

Concretely, which issues does your PR solve? (Please reference them by typing Fixes/References Inter-Actief/amelie#<issue_id>)
Fixes #926

Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no

Does your PR include any django migrations?
no

Does your PR include the proper translations (did you add translations for new/modified strings)?
no, my PR does not include translations

Does your PR include CSS changes (and did you run the compile_css.sh script in the scripts directory to regenerate the compiled.css file)?
no, my PR does not include CSS changes

Does your PR need external actions by for example the System Administrators? (Think about new pip packages, new (local) settings, a new regular task or cronjob, new management commands, etc.)?
no

Did you properly test your PR before submitting it?
no, just hope and pray for less emails

@supertom01 supertom01 requested a review from Kurocon March 3, 2025 20:48
@supertom01 supertom01 linked an issue Mar 3, 2025 that may be closed by this pull request
@supertom01 supertom01 merged commit 960be45 into main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify network error narrowcasting
3 participants